search

gnosis / dex-zksnarks

Code to generate snark proofs for batch auction result validation of the Gnosis d.exchange
46 stars 7 forks source link

New type field #7

Closed josojo closed 5 years ago

josojo commented 5 years ago

This PR would pass all tests, if pepper recognizes new field type. PR submitted

With the new type: field, which has exactly the same properties as the prime field of the alt-bn-curve, we can simulate the snarks logic much closer to the real logic in cpp. This allows better testing.

josojo commented 5 years ago

Finally, I also undid the changes in the makefile for the testing. (actually, I wanted to delete the one commit introducing this change. But since I did not find a good way to do that quickly, I simply pushed a new commit undoing the changes. Hopefully, this will not remove the changes from the other pr. I am not sure about it.)

Maybe we can merge this one rather earlier than sooner. Does not make sense that we keep on working with uint128. If @fleupold you could update your docker with the the pepper supporting field, then also we could test all of this pr.

fleupold commented 5 years ago

I'd prefer not diverging from pepper master unless we really need to. If there were comments/changes on your pull request (such as a change in the type name), we'd have to go through the procedure twice.

Let's wait if the PR is merged by Monday and otherwise base the docker image off our branch? I can also ping Max to see if he has any concerns merging this PR. Would that be ok for you?

josojo commented 5 years ago

sounds good