search

gnosis / gp-ui

7 stars 9 forks source link

Token name and logo not recognized (xDai) #412

Closed MareenG closed 3 years ago

MareenG commented 3 years ago

Describe the bug The 1Inch token is not recognized in the Explorer. Only the address is shown.

How to Reproduce Steps to reproduce the behavior:

  1. Go to CowSwap and trade 1Inch on Xdai
  2. Observe trade in Explorer

Expected behavior Logo and Name should appear for the 1Inch token

Screenshots

Bildschirmfoto 2021-04-28 um 12 35 57

https://gnosis-protocol.io/xdai/orders/0xeaf0e17c523f8789f1aca89862053a1f945bfa08cfc02fa74a09aade9d844c938bc0fe84022542e1611ff252090028df741ad67060893ccb

alfetopito commented 3 years ago

Funny thing, it loaded for me screenshot_2021-04-28_09-39-19

My guess: the call to fetch token details failed. The fallback is to show only the address.

Can you see the token details after a refresh?

alfetopito commented 3 years ago

And also, here there's a huge different between the amount precisions for you and me.

Will increase the priority on https://github.com/gnosis/gp-ui/issues/382

MareenG commented 3 years ago

Now the name and logo are displayed. Also for new trades. I tired refreshing yesterday but it still didn't load.

anxolin commented 3 years ago

Closing for now. It could have been a temporal error. We can reopen if it happens again