gnosis / ido-starter

Gnosis safe app to start auction on gnosis auction
11 stars 19 forks source link

[Feedback] - boolean input for allowlisting #14

Closed josojo closed 3 years ago

josojo commented 3 years ago

I got the feedback that selecting the allowlist contract is too customized.

We should simply have a boolean option:

And if the boolean value is ticked, then we would ask for the signer's public key. The Allowlisting contract should be read from the app's code:

on rinkeby: 0x80b8AcA4689EC911F048c4E0976892cCDE14031E
on xdai: 0x80b8AcA4689EC911F048c4E0976892cCDE14031E

(PS they are the same, we used a deterministic deployment process)

elena-zh commented 3 years ago

Also, it would be nice to add 'validation' rules for the fields in case if a user selects 'Yes' for the option 'Do you want to use whitelisting process for your auction?'. Currently, a user may fill in these fields with any value he/she wants, and that will be finished with a 'failed' transaction image.png Hence, it would be great to validate the fields on format and do not allow to leave fields empty ( if 'Yes' is selected for the option 'Do you want to use whitelisting process for your auction?'.).