search

gnosis / ido-starter

Gnosis safe app to start auction on gnosis auction
11 stars 19 forks source link

Bidding token errors #26

Closed hpmaxi closed 3 years ago

hpmaxi commented 3 years ago

Closes #21 Closes #17 Closes #30 Closes #19

This refactor a lot, it should be more smooth in performance but without messages about Invalid ERC20 or Not enough balance BEFORE submit, that is the reason that this is a draft. It doesn't mean to be a better version but for sure should be less buggy.

github-actions[bot] commented 3 years ago
josojo commented 3 years ago

Cool. let's merge after the customer test

elena-zh commented 3 years ago

Hi Maxi! Now the app is not crashed when I fill in an address that is not an ERC20 + validation messages on format and emptiness of the field appear. However, here are my issues:

  1. Pop-up to sign transaction appears when amount>balance image.png

  2. Validation message appears after pressing on the 'Build transaction' button when an address is not valid. So it will be difficult to understand what is wrong with the transaction: image.png

Could you please take a look at these issues?

josojo commented 3 years ago

Nit: image a value of 0 is perfectly fine :)

elena-zh commented 3 years ago

Hi @hpmaxi ! Great job!

17 is fixed

19 is almost fixed, however, the app is crashed when I clear out date fields (#32)

30 is fixed

21 is almost fixed, however, sometimes validation messages are not displayed on the FE side. I have created an issue for this case: #33