Some improvements for another pull request, and with more time, given that opportunity, this should be validated and prioritized.
[ ] hardhat action prints an Id, maybe here we can show a modal with the same information about the tx.
[x] Move easyAuction address to env variable and build an object with networkIds as keys to get the correct address for the network of the current safe.
[x] Extract initiateNewAuction and easyAuction to a hook that compose with useSafeAppsSDK.
[ ] Split responsibility of initiateNewAuction to validate balances and allowance beforehand.
[x] Don't be able to submit the form without everything valid, an effect with formState.errors should do it but the Controller with rules isn't working. There is a regular expression for addresses, and also some helpers from react-hook-form to validate numbers. More details are needed or I could read which guards are in the contracts.
[x] Use logo and name in manifest.json, and a favicon too.
[ ] Add a button to use all balance available?
[ ] cancel submission could be more useful.
[x] At hover we can show descriptions of each field as are in the hardhat action
[ ] An endAdornment with a symbol of the selected ERC20
[x] Add option to edit the others parameters, a group of hidden inputs behind an advanced options text, or something like that
Closes #2
Some improvements for another pull request, and with more time, given that opportunity, this should be validated and prioritized.
networkIds
as keys to get the correct address for the network of the current safe.initiateNewAuction
andeasyAuction
to a hook that compose withuseSafeAppsSDK
.initiateNewAuction
to validate balances and allowance beforehand.formState.errors
should do it but theController
withrules
isn't working. There is a regular expression for addresses, and also some helpers from react-hook-form to validate numbers. More details are needed or I could read which guards are in the contracts.manifest.json
, and a favicon too.endAdornment
with a symbol of the selected ERC20