search

gnosis / mock-contract

Simple Solidity contract to mock dependent contracts in truffle tests.
94 stars 24 forks source link

Update contracts to Solidity 0.7.0. #22

Closed chriseth closed 4 years ago

chriseth commented 4 years ago

Because I was just working in the area, I upgraded the contracts to be Solidity 0.7.0-compatible.

Of course, truffle cannot yet test it so this is not yet mergeable.

Do you have a way to support multiple versions of Solidity in parallel?

rmeissner commented 4 years ago

I don't think we have a way currently to support multiple Solidity versions in parallel 🤔 @chriseth do you by any chance have an example for that? As far as I can see openzepplin handles this via their releases, so no support for multiple version within the same version.

chriseth commented 4 years ago

The only way I see is using different branches or subdirectories. In order to keep the update-lag as small as possible, especially tools/libraries have to update quickly, and I don't see this being compatible with feature-based releases in the libraries.

rmeissner commented 4 years ago

@fleupold should be update this and get it to merge?

fleupold commented 4 years ago

Yes happy to do that. I'm off tomorrow but can get back to it next week.

fleupold commented 4 years ago

Superseeded by #25