search

gnosis / prediction-market-agent-tooling

Tools to benchmark, deploy and monitor prediction market agents.
GNU Lesser General Public License v3.0
21 stars 4 forks source link

Split `DeployableTraderAgent` into `DeployablePredictionAgent` #525

Closed kongzii closed 4 weeks ago

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces significant changes to the DeployableAgent and its subclasses within the prediction_market_agent_tooling module. The DeployableTraderAgent class has been renamed to DeployablePredictionAgent, which now focuses on prediction capabilities without trading. A new DeployableTraderAgent class is introduced for managing trades. Additionally, new methods are added for processing markets and trades, and existing methods are updated to accommodate changes in handling market data, including nullable types. The overall structure is refined to enhance clarity and functionality.

Changes

File Change Summary
prediction_market_agent_tooling/deploy/agent.py Renamed DeployableTraderAgent to DeployablePredictionAgent. Added DeployableTraderAgent class. Updated methods for market processing and trading.
prediction_market_agent_tooling/markets/agent_market.py Added ProcessedTradedMarket class. Updated store_prediction method to accept nullable processed markets. Added store_trades method.
prediction_market_agent_tooling/markets/metaculus/metaculus.py Removed submit_prediction method, added store_prediction method with updated parameters and logic.
prediction_market_agent_tooling/markets/omen/omen.py Updated store_prediction method to accept nullable processed markets. Added store_trades method for trade storage.
tests/markets/test_markets.py Added test_market_is_covered function to validate market type coverage by agent classes.

Possibly related PRs

Suggested reviewers

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between 95220a9ae6bf184a5c93a21b85d8e0d73f82ee68 and eb8a717fdf2973e8a6b30903355c165938ee59fb.
📒 Files selected for processing (1) * prediction_market_agent_tooling/markets/omen/omen.py (3 hunks)
🔇 Additional comments (3)
prediction_market_agent_tooling/markets/omen/omen.py (3)
`421-424`: **LGTM! Clear separation of concerns.** The signature change and empty implementation with a descriptive docstring clearly indicate that prediction storage is now handled alongside trades. --- `425-431`: **LGTM! Well-structured error handling.** The method implements proper null checks with appropriate warning logging, following the early return pattern. --- `444-446`: **Add null check for trade transaction IDs.** This code segment still needs the null check suggested in the previous review. The list comprehension should handle potential null trade IDs more safely.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.