search

gnosis / prediction-market-agent-tooling

Tools to benchmark, deploy and monitor prediction market agents.
GNU Lesser General Public License v3.0
21 stars 4 forks source link

Added limit as a configurable variable to DeployablePredictionAgent #532

Closed gabrielfior closed 3 weeks ago

coderabbitai[bot] commented 3 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the DeployablePredictionAgent and DeployableTraderAgent classes in the prediction_market_agent_tooling/deploy/agent.py file. A new variable, n_markets_to_fetch, is introduced to enhance market fetching flexibility. The get_markets method is updated to accept a None limit, defaulting to this new variable. Additionally, the process_market method in DeployableTraderAgent is enhanced to include trade execution logic, logging, and conditional trade storage. Changes are also made to the APIKeys class in config.py and the import structure in various files, reflecting a transition to the safe_eth library.

Changes

File Path Change Summary
prediction_market_agent_tooling/deploy/agent.py - Added variable n_markets_to_fetch: int = MAX_AVAILABLE_MARKETS in DeployablePredictionAgent.
- Updated get_markets method to allow limit to be None, defaulting to self.n_markets_to_fetch.
- Modified process_market method in DeployableTraderAgent to include trade execution logic and logging.
- Updated after_process_market method to conditionally store trades based on store_trades.
prediction_market_agent_tooling/config.py - Updated check_if_is_safe_owner method to use SafeV141 instead of Safe for instantiation.
- Updated import paths for EthereumClient and SafeV141.
prediction_market_agent_tooling/tools/safe.py - Updated imports from gnosis to safe_eth for various Ethereum client interactions.
- Modified create_safe function to use SafeV141 instead of Safe and added type annotation for expected_safe_address as ChecksumAddress.
prediction_market_agent_tooling/tools/web3_utils.py - Updated import for Safe to SafeV141 from safe_eth.safe.
tests_integration_with_local_chain/safe/conftest.py - Updated test_safe fixture to return SafeV141 instead of Safe.
tests_integration_with_local_chain/markets/omen/test_omen.py - Skipped multiple tests due to local chain functionality issues and added comments for required adjustments.
tests_integration_with_local_chain/safe/test_erc20_transfer_using_safe.py - Updated import for Safe to SafeV141 from safe_eth.safe.
tests_integration_with_local_chain/safe/test_safe.py - Updated parameter types in test functions to use SafeV141 instead of Safe.

Possibly related PRs

Suggested reviewers

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.