gnosis / prediction-market-agent-tooling

Tools to benchmark, deploy and monitor prediction market agents.
GNU Lesser General Public License v3.0
21 stars 4 forks source link

DB cache in form of decorator #534

Closed kongzii closed 2 weeks ago

coderabbitai[bot] commented 3 weeks ago

[!WARNING]

Rate limit exceeded

@kongzii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between e8d00ec6b3b28f7410b389c058b8ed3969854c6f and 1c8028fbe7cf4d87558eac168881b0b8fe6f2d60.

Walkthrough

This pull request introduces a new caching mechanism using a PostgreSQL database through the db_cache decorator, which replaces previous in-memory caching strategies in various functions across multiple files. It includes the creation of a FunctionCache model to store function metadata and results, and updates several existing functions to utilize this new caching approach. Additionally, it removes certain classes related to data storage and adds comprehensive unit tests to validate the caching behavior.

Changes

File Change Summary
prediction_market_agent_tooling/tools/caches/db_cache.py Introduced a new caching mechanism with FunctionCache model and db_cache decorator, supporting various parameters for flexible caching behavior.
prediction_market_agent_tooling/tools/google.py Updated search_google function to use @db_cache(max_age=timedelta(days=1)) instead of in-memory caching, modifying the import statement accordingly.
prediction_market_agent_tooling/tools/is_invalid.py Replaced @persistent_inmemory_cache with @db_cache in is_invalid function, maintaining the function's internal logic.
prediction_market_agent_tooling/tools/is_predictable.py Updated @persistent_inmemory_cache to @db_cache for both is_predictable_binary and is_predictable_without_description functions, preserving their signatures and logic.
prediction_market_agent_tooling/tools/relevant_news_analysis/relevant_news_analysis.py Modified date handling in analyse_news_relevance and get_certified_relevant_news_since functions, changing parameter types and simplifying logic.
prediction_market_agent_tooling/tools/tavily/tavily_models.py Removed TavilyResponseModel class, eliminating structured representation of Tavily responses in the database.
prediction_market_agent_tooling/tools/tavily/tavily_search.py Added @db_cache to tavily_search, updated parameter types from days to news_since, and modified related logic for handling date parameters.
prediction_market_agent_tooling/tools/tavily/tavily_storage.py Deleted TavilyStorage class, which managed storage and retrieval of TavilyResponse data in SQL database.
tests/conftest.py Added a new pytest fixture keys_with_sqlalchemy_db_url to provide an instance of APIKeys initialized with a SQLAlchemy database URL.
tests/tools/test_db_cache.py Introduced unit tests for db_cache decorator, covering various input types and caching scenarios, ensuring correct behavior of the caching mechanism.

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
kongzii commented 3 weeks ago

Also did a script to refill the data: https://github.com/gnosis/prediction-market-agent-tooling/pull/540 But it's too hacky to be merged, so just closed the PR to keep it at least somewhere.