search

gnosis / prediction-market-agent-tooling

Tools to benchmark, deploy and monitor prediction market agents.
GNU Lesser General Public License v3.0
22 stars 4 forks source link

Fix(omen_contracts): update kleros proxy deployment #550

Closed alcercu closed 3 hours ago

alcercu commented 2 weeks ago

As mentioned in issue #495, the script in charge of loading dispute metadata in the kleros proxy that was being used could have problems loading. This fix changes the address to a new proxy recently deployed, here are the details:

If you have any question or requested change, don't hesitate to ask!

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request focus on modifying the OmenKlerosContract class within the omen_contracts.py file. Specifically, the from_arbitrator static method has been updated to return a new address for the KLEROS_31_JURORS_WITH_APPEAL arbitrator. The previous address was changed from 0x29f39de98d750eb77b5fafb31b2837f079fce222 to 0x5562Ac605764DC4039fb6aB56a74f7321396Cdf2. Minor formatting adjustments and comments were also made, but they do not impact the overall functionality.

Changes

File Path Change Summary
prediction_market_agent_tooling/markets/... Updated from_arbitrator method in OmenKlerosContract to return a new address for KLEROS_31_JURORS_WITH_APPEAL. Minor formatting and comments adjusted.

Possibly related PRs

Suggested reviewers

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
kongzii commented 1 week ago

Hi @alcercu , thanks a lot! Sorry for the late response, I'm on DevCon this week.

I see there is still the We do not recognize this arbitrator. Do not believe this information unless you trust them message on Reality, is this something you can fix or should I ask someone from Reality?

And second question, this should be changed also in Olas' market creator, do you want to contribute there as well, or should I? See https://github.com/valory-xyz/market-creator/pull/120/files.

alcercu commented 4 days ago

hello @kongzii! No worries, same here. We were all at devcon 🙌🏻 Regarding your first question, we already messaged Reality's maintainer to add it, will ping here when it's added. As for the second point, yes please, feel free to create the PR in Olas if it's needed. But please tag this issue/me so I can keep track 🫡

kongzii commented 1 day ago

Cool thanks! Then I'll wait and once it's set up on Reality, I'll merge this + create it in Olas.

alcercu commented 8 hours ago

Hey @kongzii! The arbitrator has been added to Reality 🙌🏻 https://github.com/RealityETH/reality-eth-monorepo/commit/23b662b86d40c49a9f319f9cce8ad74a467099b1 image

kongzii commented 3 hours ago

Nice, thanks!

kongzii commented 3 hours ago

Pipelines will error out as credentials are missing in fork PRs, but this change shouldn't bring any problems so will just merge 🤞