search

gnosis / prediction-market-agent-tooling

Tools to benchmark, deploy and monitor prediction market agents.
GNU Lesser General Public License v3.0
22 stars 4 forks source link

First attempt at DB_Manager #555

Open gabrielfior opened 1 week ago

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces multiple changes across several files, primarily focusing on enhancing the handling of database connections and serialization processes. Key modifications include the refactoring of the APIKeys class to improve instance method calls, the introduction of a DBManager class for centralized database management, and updates to caching mechanisms. Additionally, new serialization functions have been added, and existing tests have been updated to reflect these changes, ensuring consistent usage of parameters across the codebase.

Changes

File Change Summary
prediction_market_agent_tooling/config.py Modified APIKeys class methods to use self.model_fields for instance context; updated check_if_is_safe_owner method to validate SAFE_ADDRESS.
prediction_market_agent_tooling/markets/omen/data_models.py Updated from_tuple method signature to accept a variable-length tuple; simplified instance creation logic.
prediction_market_agent_tooling/tools/caches/db_cache.py Refactored db_cache decorator to utilize DBManager for session management and table creation; removed custom JSON serialization logic.
prediction_market_agent_tooling/tools/caches/serializers.py Introduced new file with functions for JSON serialization and deserialization of custom types.
prediction_market_agent_tooling/tools/db/db_manager.py Added DBManager class for managing database connections and sessions, including methods for session handling and table creation.
prediction_market_agent_tooling/tools/relevant_news_analysis/relevant_news_cache.py Updated RelevantNewsResponseCache to use DBManager for database interactions; changed constructor to accept APIKeys.
tests/conftest.py Replaced database connection fixture with one using PostgreSQLExecutor and improved lifecycle management.
tests/tools/db/test_db_manager.py Added test to verify singleton behavior of DBManager.
tests/tools/test_db_cache.py Updated test functions to use new database connection fixture.
tests_integration/tools/test_relevant_news_analysis.py Modified test to utilize APIKeys for database URL management, enhancing security handling.

Possibly related PRs

Suggested reviewers

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between e18d477913294e409a2d3e38c1d8656a07b49104 and fbbd617b2747c6bcd646b5e661dcecdf3c3d0a80.
📒 Files selected for processing (2) * `prediction_market_agent_tooling/tools/db/db_manager.py` (1 hunks) * `tests/tools/db/test_db_manager.py` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * prediction_market_agent_tooling/tools/db/db_manager.py * tests/tools/db/test_db_manager.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
gabrielfior commented 1 week ago

Closing this since this has less priority than the upcoming general agent milestone - also, this PR apparently solved the most pressing issues.