gnosis / safe-cmm-app-react

MIT License
2 stars 2 forks source link

Avoid app crashing when amounts are invalid #234

Closed alfetopito closed 3 years ago

alfetopito commented 3 years ago

Description

Sometimes totalValue is NaN.

screenshot_2020-12-15_13-28-00

Hard to reproduce bug. Saw this sporadically, not sure what's causing it.

In any way, this change prevents app crashing when totalValue is falsy or NaN.

To Test

Fill in all fields in the deploy form. Sometimes the total value calculation fails.

Background

N/A

ghost commented 3 years ago

Travis automatic deployment: