gnosis / safe-cmm-app-react

MIT License

2 stars 2 forks source link

Bug/empty string on inputs #241

Closed alfetopito closed 3 years ago

alfetopito commented 3 years ago

Description

Fixing - once and for all - issues with bad input breaking the app

Related to #238

Found out what was causing:

App to break when copy/pasting values into the input (#238 issue 2)
Issue that prevented user from submitting the form, which I attempted to fix on #238 issue 1

To Test

On deploy form, pick any 2 tokens
Copy paste the full price estimation value into ALL inputs

[ ] Notice that the copied value start with an empty string
[ ] It should not cause the app to break
[ ] You should be able to submit the form

Background

Managed to reproduce user error. This should fix it :crossed_fingers:

ghost commented 3 years ago

Travis automatic deployment:

🔐 Safe app link: To be added as a custom app on Safe Multisig Rinkeby, Mainnet or xDai
📖 Storybook: Component stories