gnosis / safe-cmm-app-react

MIT License

2 stars 2 forks source link

Feature/#191/trades #244

Closed alfetopito closed 3 years ago

alfetopito commented 3 years ago

Description

Closes #191

Trades page screenshot_2020-12-29_10-57-30

To Test

Go to strategies tab
Expand one active strategy
Click on Trades

[ ] Trades should load for your strategy (given that there were any trades for it)

Repeat the same for closed strategies
Go back to active strategies
Expand the same strategy and trades again

[ ] Trades (if any) should be pre-loaded

Close the app, open it again
Visit the same strategies and trades visited before

[ ] Trades (if any) should be pre-loaded

Background

Loading trades since strategy deployment block
Additional check at every 5 blocks
Storing trades on global state: switching tabs won't lose the history
Storing trades on local storage: closing the app won't lose the history

gnosis-info commented 3 years ago

Travis automatic deployment:

🔐 Safe app link: To be added as a custom app on Safe Multisig Rinkeby, Mainnet or xDai
📖 Storybook: Component stories

andre-meyer commented 3 years ago

@alfetopito See my comments but nothing urgent. Feel free to merge