gnosisguild / tabula

Instant web3 publications for writers, DAOs, and any Ethereum-based account.
https://tabula.gg
GNU Lesser General Public License v2.1
30 stars 7 forks source link

Block picker keyboard navigation is a little buggy #271

Open auryn-macmillan opened 11 months ago

auryn-macmillan commented 11 months ago

Describe the bug There are three related issues with block picker keyboard navigation:

  1. [up] and [down] navigate the block picker, while [left] and [right] move the cursor in the document.
  2. navigating below the fold in the block picker does not scroll the block picker window; one loses visibility on which block-type is selected and must use the mouse to scroll the view down.
  3. text in the block picker is not needed.

To Reproduce Steps to reproduce the behavior:

  1. start a line with [/] and then press the arrow keys

Expected behavior

  1. all four arrow keys should navigate in the block picker
  2. the block picker should scroll automatically to keep the cursor visible
  3. we should remove the text from the various options in the block picker, these could perhaps be replaced with hover text.
cedricwaxwing commented 10 months ago

@auryn-macmillan Unless I'm misunderstanding this, I'm not necessarily convinced that the text should be removed from the options. Is this just a space saver for the menu, or do you have other concerns?

auryn-macmillan commented 10 months ago

I think if we keep the text, we should stick to one column and ensure each item is limited to one row.

e.g. Tabula

Screencast from 10-30-2023 10:51:57 AM.webm

e.g. Notion

image

e.g. Skiff

image