gnosisguild / tabula

Instant web3 publications for writers, DAOs, and any Ethereum-based account.
https://tabula.gg
GNU Lesser General Public License v2.1
29 stars 7 forks source link

Connect buttons silently fail if your wallet is on an unsupported network. #56

Closed auryn-macmillan closed 2 years ago

auryn-macmillan commented 2 years ago

When you hit "Connect Wallet" and then select "Metamask" if metamask is connected to an unsupported network. We should include a prompt to switch to a supported network, including a list of the supported networks.

asgeir-s commented 2 years ago

Thank you, @auryn-macmillan 🙏

Expanding a bit on this:

When a user connects a wallet from the Tabula landing page:

When a user connects a wallet from an article or a publication page (requires: #62):

Sample implementations, see: https://github.com/NoahZinsmeister/web3-react/blob/main/packages/example-next/components/ConnectWithSelect.tsx

Also:

cedricwaxwing commented 2 years ago

Adding one more here since it's semi-related. If you click connect wallet and then select Metamask, but don't have Metamask extension on your browser, it fails silently as well.

auryn-macmillan commented 2 years ago

If the user attempts to connect to Metamask without the extension installed, display a message saying "You'll need to install MetaMask to continue. Once you have it installed, go ahead and refresh the page."

@cedricwaxwing, perhaps it would be better to just hide metamask as an option if no injected web3 is detected?

cedricwaxwing commented 2 years ago

@auryn-macmillan maybe not better, but definitely quicker to implement and good enough for now. 👍