search

gnosisguild / zodiac-guard-scope

A transaction guard that allows the owner to limit the multisig signers to calling specific function signatures on specific contracts.
GNU Lesser General Public License v3.0
34 stars 19 forks source link

Remove unused dependencies #1

Closed bh2smith closed 3 years ago

bh2smith commented 3 years ago

To see a list of removed dependencies you can execute the following

git checkout main
yarn global add depcheck
depcheck

Which results in 

Unused dependencies
* @gnosis.pm/mock-contract
* @openzeppelin/contracts
* argv
* solc
Unused devDependencies
* @types/mocha
* @types/node
* debug
* eslint-plugin-no-only-tests
* prettier-plugin-solidity
* solhint-plugin-prettier
* ts-node
* typescript
Missing dependencies
* @ethersproject/constants: ./test/ScopeGuard.spec.ts

Then checkout this branch and run depcheck again (resulting in No depcheck issue).

auryn-macmillan commented 3 years ago

Closing this one as it's stale now. Thanks for prompting us to fix this @bh2smith :smile:

Worth noting that some of the dependencies that the tool reports as unused are actually used in the solidity code. e.g. OZ and safe-contracts.