search

gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control
https://roles.gnosisguild.org
GNU Lesser General Public License v3.0
80 stars 39 forks source link

Merge in Roles App #100

Closed samepant closed 2 years ago

samepant commented 2 years ago

Just opening this to get it on the radar, is there any reason it shouldn't be merged in @asgeir-eth ?

asgeir-s commented 2 years ago

Just opening this to get it on the radar, is there any reason it shouldn't be merged in @asgeir-eth ?

If I remember correctly we started working on this branch due to it was a desire at the time for keeping the main branch as "what's in production". With the new pipeline with "prod deployment from release" and "dev deployment for push to main", it probably makes sense to merge this to main and make new PRs to main. What do you think @auryn-macmillan?

However, I don't think this is production-ready yet. @carlosfebres: do you have any updates on what's left to make this production-ready?

asgeir-s commented 2 years ago

Just opening this to get it on the radar, is there any reason it shouldn't be merged in @asgeir-eth ?

I really do not see any reason not to merge it (even if it's not finished) as it only means that it goes to the dev environment.