Closed jfschwarz closed 2 years ago
Since I'm working on integrating the SDK with the subgraph and looking to use consistent naming I've stumbled over some names that I think could be improved in the subgraph schema. I'm proposing the following updates:
Parameter.theFunction -> Parameter.owningFunction Parameter.parameterIndex -> Parameter.index Parameter.parameterType -> Parameter.type Parameter.parameterComparison -> Parameter.comparison Parameter.parameterComparisonValue -> Parameter.comparisonValue
Parameter.theFunction
Parameter.owningFunction
Parameter.parameterIndex
Parameter.index
Parameter.parameterType
Parameter.type
Parameter.parameterComparison
Parameter.comparison
Parameter.parameterComparisonValue
Parameter.comparisonValue
Function.functionSig -> Function.sighash
Function.functionSig
Function.sighash
MemberRole -> RoleAssignment
MemberRole
RoleAssignment
RolesModifier.exec_target -> RolesModifier.target
RolesModifier.exec_target
RolesModifier.target
Let me know what you think, @manboy-eth... 🙌
Since I'm working on integrating the SDK with the subgraph and looking to use consistent naming I've stumbled over some names that I think could be improved in the subgraph schema. I'm proposing the following updates:
Parameter.theFunction->Parameter.owningFunctionParameter.parameterIndex->Parameter.indexParameter.parameterType->Parameter.typeParameter.parameterComparison->Parameter.comparisonParameter.parameterComparisonValue->Parameter.comparisonValueFunction.functionSig->Function.sighashMemberRole->RoleAssignmentRolesModifier.exec_target->RolesModifier.targetLet me know what you think, @manboy-eth... 🙌