search

gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control
https://roles.gnosisguild.org
GNU Lesser General Public License v3.0
80 stars 39 forks source link

Next.js partial prerender test #234

Closed samepant closed 8 months ago

samepant commented 8 months ago

The page building time on the the role view was taking a long time, leading to awkward pause in navigation.

i moved fetchOrInitRole to the RolesView component of the root page, so we get Initial page load -> RolesView rendered on server -> results streamed in to client. If this looks good i can apply the pattern to the rest of the pages

before:

https://github.com/gnosisguild/zodiac-modifier-roles/assets/6718506/6f6143a6-b128-4127-a164-819382d71b55

after:

https://github.com/gnosisguild/zodiac-modifier-roles/assets/6718506/3bb21e86-5625-41bc-b568-7e7cc900fb90

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-roles-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 5:35pm
zodiac-roles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 5:35pm
samepant commented 8 months ago

actually, not sure this is doing what i think it is, going to keep futzing with it

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7875579487

Details

Totals Coverage Status
Change from base Build 7874471421: 0.0%
Covered Lines: 665
Relevant Lines: 666
💛 - Coveralls