Role View Layout changes

[samepant]

Dropping commits here for updates to the permissions view

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zodiac-roles-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 27, 2024 5:29pm
zodiac-roles-docs	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Feb 27, 2024 5:29pm

[coveralls]

Pull Request Test Coverage Report for Build 8068840343

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.719%

---

Totals
Change from base Build 7991153917:	0.0%
Covered Lines:	665
Relevant Lines:	666

---

💛 - Coveralls

[jfschwarz]

I feel all the labels add a lot of clutter but are not really crucial for making sense of the UI. Just hiding them all looks more zen:

[jfschwarz]

I'm also not quite sure if it's any useful to allow collapsing complex conditions. Looking at a complex condition without the children is pretty useless, so I don't think collapsing them would help the user to get an overview.

My original intention was to collapse complex parameters if no condition is set on them.

[samepant]

I'm also not quite sure if it's any useful to allow collapsing complex conditions. Looking at a complex condition without the children is pretty useless, so I don't think collapsing them would help the user to get an overview.

This makes sense to me, i'll remove the collapsibility if there is a condition.

I feel all the labels add a lot of clutter but are not really crucial for making sense of the UI. Just hiding them all looks more zen

when i first started working on this view a couple weeks ago, i got a little lost with all the information, so i added in the labels to help me keep it straight. After a while of looking at it, having less labels is more clean visually, and now that I know what everything is i can still grok the info.

However, I think it's a tradeoff on how legible we want this UI to be to new users or even non-developers. Someone less familiar with what a parameter or a type would benefit from the labels.

A key use of this interface is allowing people to share and communicate about Roles — it's an opportunity to encourage the use of a specific set of terms to avoid confusion. Imagine a non technical ENS delegate checking a Roles permission change, i'd want them to be able to be informed by the ui, and to be able to ask questions using the specific language the labels show.

[jfschwarz]

when i first started working on this view a couple weeks ago, i got a little lost with all the information, so i added in the labels to help me keep it straight. After a while of looking at it, having less labels is more clean visually, and now that I know what everything is i can still grok the info.

However, I think it's a tradeoff on how legible we want this UI to be to new users or even non-developers. Someone less familiar with what a parameter or a type would benefit from the labels.

A key use of this interface is allowing people to share and communicate about Roles — it's an opportunity to encourage the use of a specific set of terms to avoid confusion. Imagine a non technical ENS delegate checking a Roles permission change, i'd want them to be able to be informed by the ui, and to be able to ask questions using the specific language the labels show.

Makes sense 👍