Fix Roles Module Proxy Address calculation

gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control

https://roles.gnosisguild.org

GNU Lesser General Public License v3.0

80 stars 39 forks source link

Fix Roles Module Proxy Address calculation #250

Closed Ktl-XV closed 7 months ago

Ktl-XV commented 7 months ago

When using setUpRolesMod the predicted Roles Module Proxy Address is not computed correctly. The multicall transaction still goes through because it "sets" permissions on an empty account, which does not revert.

vercel[bot] commented 7 months ago

@Ktl-XV is attempting to deploy a commit to the Gnosis Guild Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zodiac-roles-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 15, 2024 10:26am

github-actions[bot] commented 7 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Ktl-XV commented 7 months ago

I have read the CLA Document and I hereby sign the CLA

Ktl-XV commented 7 months ago

(The CLA link is broken)

jfschwarz commented 7 months ago

Good catch! Thank you for the fix, @Ktl-XV 🙏