Diff view fixes - Githubissues

gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control

https://roles.gnosisguild.org

GNU Lesser General Public License v3.0

80 stars 39 forks source link

Diff view fixes #255

Closed jfschwarz closed 6 months ago

jfschwarz commented 6 months ago

some styling fixes for the diff view
- fix diff highlighting (was a bit broken after the recent UI improvements)
- example: /eth:0xBd1099dFD3c11b65FB4BB19A350da2f5B61Efb0d/roles/BALANCER-MANAGER/diff/USYo5yY5aE89Q100Zv5IGjy177hqNAvxQbZv5vR4lU
- fix diff display for wildcard permissions
- example: /eth:0xBd1099dFD3c11b65FB4BB19A350da2f5B61Efb0d/roles/BALANCER-MANAGER/diff/yqdCiJrM5DBkl6CSNdU2aQHiS2FBcz7Ko1kGtuguuE
optimization: don't revoke empty function-scoped targets (saves some calls)
add a new diff page for comparing two permission sets
- example:/permissions/eth/USYo5yY5aE89Q100Zv5IGjy177hqNAvxQbZv5vR4lU/diff/ofZq3jUleI5cexK2TdfNwFShYU97sWMjSgt9hGxk

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zodiac-roles-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2024 9:44am
zodiac-roles-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2024 9:44am

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8686867494

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.719%

Totals
Change from base Build 8636769871:	0.0%
Covered Lines:	665
Relevant Lines:	666

💛 - Coveralls