gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control
https://roles.gnosisguild.org
GNU Lesser General Public License v3.0
80 stars 39 forks source link

Let the user add target's ABI manually #76

Closed carlosfebres closed 2 years ago

carlosfebres commented 2 years ago

We need to get the ABI of the targets to know the functions of the contract. In mainnet & rinkeby we can get the ABIs from etherscan, but we need to support many other chains

@cedricwaxwing in case we can't get the ABI from the explorer, the user would need to provide it. We could have a text area field somewhere (or maybe use a modal for this).

cedricwaxwing commented 2 years ago

https://www.figma.com/file/h2nRHyTfrJb2hhXME6FDX4?node-id=345:13614#151641806

cedricwaxwing commented 2 years ago

@carlosfebres I see this is in "Ready for Review", but after pulling the most recent changes, I'm seeing this in the target configuration still:

image
carlosfebres commented 2 years ago

Oh you're right, sorry. I thought that part was in a different issue