search

gnosisguild / zodiac-modifier-roles

Smart account toolkit for role-based access control
https://roles.gnosisguild.org
GNU Lesser General Public License v3.0
80 stars 39 forks source link

Create UI for parameter conditions #88

Closed cedricwaxwing closed 2 years ago

cedricwaxwing commented 2 years ago

Figma

cedricwaxwing commented 2 years ago

@carlosfebres these now have the "types" next to the param names.

image

https://www.figma.com/file/h2nRHyTfrJb2hhXME6FDX4/Zodiac-Roles-Modifier?node-id=398%3A18771

cedricwaxwing commented 2 years ago
image

@carlosfebres The function checkbox shouldn't go to indeterminate if a param condition is added. The indeterminate checkbox made more sense before when I had the mockup with params that were checkable, since the indeterminate function checkbox would indicate that some of the children (params) are not checked, and clicking on it would allow/revoke all of them. However, this wouldn't make any sense with out current implementation of the params.

This should be relatively easy to solve, I think just creating a standard checkbox for the function (no logic to check status of params), and then if it's set to unchecked, then the function exec options and param conditions UI can be disabled.