gnosisguild / zodiac-module-reality

A Zodiac module that uses Reality.eth as an oracle for triggering execution on a Safe.
GNU Lesser General Public License v3.0
102 stars 52 forks source link

Incorrect setup could cause addProposal() to revert #69

Closed fnanni-0 closed 1 year ago

fnanni-0 commented 2 years ago

Are L117 and L139 require(...) really needed? If yes and if they are intended to prevent askQuestionWithMinBond() from reverting if the setup was incorrect, then require(timeout < 365 days, "Timeout has to be smaller than 365 days") should probably be checked too, right? See Realitio v3. Anyway, I don't think this is an issue, but it caught my attention.