gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

"Open Roles App" link is formatted incorrectly #154

Closed auryn-macmillan closed 1 year ago

auryn-macmillan commented 1 year ago

Describe the bug The "Open Roles App" link in roles mod on the Zodiac Safe App is incorrectly formatted. image It enters the Safe address as the URL paramter, rather than the module address. For example. the safe 0xBFA7 has the module 0x583d... attached.

The link URL is currently https://gnosis-safe.io/app/gno:0xBFA7a31A593C56f2F824Ed7537D30293b8a81710/apps?appUrl=https://roles.gnosisguild.org/%23/gno:0xBFA7a31A593C56f2F824Ed7537D30293b8a81710 but it should be https://gnosis-safe.io/app/gno:0xBFA7a31A593C56f2F824Ed7537D30293b8a81710/apps?appUrl=https://roles.gnosisguild.org/%23/gno:0x583d5235f09aAaAD8c148211A2782A2010ebaA0d.

Side Quest It would be great if we could get have the link not open in a new tab. Not sure if it's possible to switch domains in a safe app though.