gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

Zodiac Reality Module stuck, doesn't allow to continue after filling in name #198

Open greenlucid opened 1 year ago

greenlucid commented 1 year ago

Describe the bug

I can't get through the first step of the Zodiac Reality Module wizard, in which it asks for an ENS

To Reproduce Steps to reproduce the behavior:

  1. Connect to Safe, in Mainnet
  2. Open Zodiac App
  3. Open Reality Module
  4. Write in an ENS for a Snapshot the Safe controls
  5. (bug occurs)

Expected behavior

I was expected to stumble upon this https://github.com/gnosis/zodiac-safe-app/issues/194 since the PR with the fix wasn't merged yet, but it doesn't do anything, with the button remaining disabled.

Even if it froze, I would've expect some kind of error to appear in the console, or some network request to fetch something from snapshot, but that wasn't the case either. It's just unreactive.

Screenshots / logs

image

Relevant environment details:

Same as the other issues I've reported. Frame Wallet.

Additional context

None

greenlucid commented 1 year ago

Investigated a bit through the network log, it's making requests here: https://hub.snapshot.org/api/spaces/tralara.eth/poke But this endpoint is returning error 307. When you access the following endpoint, then it seems to be valid: https://hub.snapshot.org/api/spaces/tralara.eth

Offending function: https://github.com/gnosis/zodiac-safe-app/blob/b596798d5073da7a4850b974eaec3f2f14e52ffb/packages/app/src/services/snapshot.ts#L28

Not poking seems to solve the issue

greenlucid commented 1 year ago

Pasting a Discord conversation in https://discord.gg/snapshot #developers channel that could shed some light

green — Yesterday at 3:42 PM hey, is the following endpoint valid? https://hub.snapshot.org/api/spaces/tralara.eth/poke it's returning error code 307. a query is being made from Reality Module, a subapp in the Zodiac Module app in app.safe.global

green — Yesterday at 4:11 PM related issue: https://github.com/gnosis/zodiac-safe-app/issues/198#issuecomment-1477971646 Is it still true that calling /poke refreshes the cache of the snapshot space data, or is this behavior no longer the case?

Chaitu⚡ — Yesterday at 6:34 PM Hey @green Yes it is still valid, but can be useful for this case https://docs.snapshot.org/user-guides/spaces/create/alternative-way-to-create-a-space It should not have any relation to zodiac, as you mentioned in comment https://hub.snapshot.org/api/spaces/tralara.eth can be used to get the space, even better if they use https://docs.snapshot.org/tools/graphql-api#space