gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

feat: restrict osnap quorum to uint256 #210

Closed Reinis-FRP closed 1 year ago

Reinis-FRP commented 1 year ago

Fix a bug

Bug Report

oSnap module can be deployed with rules containing arbitrary string for vote quorum. This can cause ambiguity when verifying proposal if the quorum value was not number.

Implementation

Restricts votingQuorum param to accept only uint256 when deploying new oSnap module.

vercel[bot] commented 1 year ago

@Reinis-FRP is attempting to deploy a commit to the Gnosis Guild Team on Vercel.

A member of the Team first needs to authorize it.