search

gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

Fix the Wonderland issues #223

Closed asgeir-s closed 1 year ago

asgeir-s commented 1 year ago

Fixes the Zodiac app-related issues found in the Wonderland papers.

The issues are related to blockchain explorer configurations.

Before merging We must add those environment variables to the production environment:

REACT_APP_ETHERSCAN_KEY=
REACT_APP_GOERLI_ETHERSCAN_KEY=
REACT_APP_GNOSISSCAN_KEY=
REACT_APP_POLYGONSCAN_KEY=
REACT_APP_BSCSCAN_KEY=
REACT_APP_OPTIMISTIC_ETHERSCAN_KEY=
REACT_APP_ARBISCAN_KEY=
REACT_APP_SNWOTRACE_KEY=
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-safe-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 3:30pm
zodiac-safe-app-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 3:30pm
jfschwarz commented 1 year ago

@manboy-eth, we still have to add the new env vars the the GitHub workflow yaml files, reading from project secrets.

For setting the project secrets admin access is required. I don't have it. Can one you add these, @samepant @auryn-macmillan ?

REACT_APP_ETHERSCAN_KEY=
REACT_APP_GOERLI_ETHERSCAN_KEY=
REACT_APP_GNOSISSCAN_KEY=
REACT_APP_POLYGONSCAN_KEY=
REACT_APP_BSCSCAN_KEY=
REACT_APP_OPTIMISTIC_ETHERSCAN_KEY=
REACT_APP_ARBISCAN_KEY=
REACT_APP_SNOWTRACE_KEY=
auryn-macmillan commented 1 year ago

@jfschwarz, I've gone ahead and added you as an admin

jfschwarz commented 1 year ago

I've added the following project secrets:

image