search

gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

Add AMB & Exit Module #26

Closed carlosfebres closed 3 years ago

carlosfebres commented 3 years ago

I've added the AMB & Exit modules in this commit https://github.com/gnosis/safe-module-manager/pull/21/commits/b0004dfad28121c4b3dbc425fd93c22c74d3d8b2

I've created the following modals:

EXIT AMB
Screenshot from 2021-08-31 02-14-28 Screenshot from 2021-08-31 02-14-16
carlosfebres commented 3 years ago

@auryn-macmillan @samepant do you think the fields names/layout and module descriptions are fine?

auryn-macmillan commented 3 years ago

Yeah, they look good to me.

For the SafeExit module, we should give the user the option to deploy a circulating supply contract.

carlosfebres commented 3 years ago

@auryn-macmillan ok, should we only let the user deploy a new circulating supply contract or provide both options (deploy and enter an address)?

auryn-macmillan commented 3 years ago

They should have both options.

If they deploy a new circulating supply contract, we should also allow them to set the circulating supply.

carlosfebres commented 3 years ago

They should have both options.

If they deploy a new circulating supply contract, we should also allow them to set the circulating supply.

Added feature in PR https://github.com/gnosis/safe-module-manager/pull/27