BNB smart chain error when adding modules

samepant commented 2 years ago

Seeing this error when attempting to add a module on BNB:

2RealityModuleModal.tsx:140 Error deploying module:  TypeError: Cannot read properties of undefined (reading 'realityETH')
    at Object.t.getFactoryAndMasterCopy (factory.js:59:31)
    at t.deployAndSetUpModule (factory.js:7:41)
    at J (index.ts:142:7)
    at RealityModuleModal.tsx:129:19
    at l (runtime.js:63:40)
    at Generator._invoke (runtime.js:293:22)
    at Generator.next (runtime.js:118:21)
    at n (asyncToGenerator.js:3:20)
    at c (asyncToGenerator.js:25:9)
    at asyncToGenerator.js:32:7

Transaction window never pops up.

samepant commented 2 years ago

this issue appears to be the same error https://github.com/gnosis/zodiac/issues/56

NeoXtreem commented 2 years ago

@samepant How's it going with this fix?

samepant commented 2 years ago

@carlosfebres I tried to sort this out, and i'm not sure why that object would be undefined for BSC. Any ideas?

carlosfebres commented 2 years ago

@samepant That issue got solved in this PR https://github.com/gnosis/zodiac/pull/55. We need to update the Zodiac app to use Zodiac v1.0.11.

samepant commented 2 years ago

fixed in this release: https://github.com/gnosis/zodiac-safe-app/releases/tag/v1.0.7

gnosisguild / zodiac-safe-app

BNB smart chain error when adding modules #60