search

gnosisguild / zodiac-safe-app

https://gnosis-safe.io/app/share/safe-app?appUrl=https://zodiac.gnosisguild.org/&chainId=5
GNU Lesser General Public License v3.0
26 stars 28 forks source link

Create Monitoring Flow UI #96

Closed juliopavila closed 2 years ago

juliopavila commented 2 years ago

This PR contains the UI for #86 Integrate open zeppelin as a monitoring service

netlify[bot] commented 2 years ago

Deploy Preview for gnosis-zodiac-app ready!

Name Link
Latest commit 2e6f805aef03302921b3af39c2e681e9d737a0b5
Latest deploy log https://app.netlify.com/sites/gnosis-zodiac-app/deploys/632b06c5202d540008712272
Deploy Preview https://deploy-preview-96--gnosis-zodiac-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for neon-conkies-9b23dd ready!

Name Link
Latest commit 2e6f805aef03302921b3af39c2e681e9d737a0b5
Latest deploy log https://app.netlify.com/sites/neon-conkies-9b23dd/deploys/632b06c5e7eac300094a0369
Deploy Preview https://deploy-preview-96--neon-conkies-9b23dd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

asgeir-s commented 2 years ago

Does it exist an environment where we can test the calls (seems to be failing locally)?

Looks like a good start 💪 Now we just need to set up the actual notifications/alerts based on the Reality.eth events. I am wondering how this will work with custom oracles that are not yet deployed 🤔 But let's get it working with the standard Reality.eth oracle first.

Also, I hope we are able to find a solution where we do not have to add the whole amazon-cognito-identity-js package just to get the token. That we, instead, can find a more lightweight solution to this.

I am also wondering why we use a class for the OSDefenderService, why not just use stateless functions, as we do for the rest of the services?

Also, it might make sense if we move all the OS defender-related stuff to one place. For instance src/service/osDefender/ and if its not generic (will only ever be useful for the Reality Module setup) place it in src/views/RealityModule/service (I know this in unconventional, but this app really exists of a set of "small apps" so it will be good to be able to encapsulate the apps somehow).