search

gnosygnu / xowa

xowa offline wiki application
Other
380 stars 40 forks source link

packed hover galleries #325

Open desb42 opened 5 years ago

desb42 commented 5 years ago

following on from both #323 and #324 en.wikipedia.org/wiki/Help:Pictures (I seem to have hit a vein of something) About 2/3 down the page is a gallery of cats. first off it seems packed-hover has not been implemented, it falls back to packed. But this is not the point I want to discuss Looking at the html generated, wiki generates float values where xowa is using integers. that is

<li class="gallerybox" style="width: 157.33333333333px"><div style="width: 157.33333333333px">

 whereas xowa

<li id="xowa_gallery_li_0" class="gallerybox" style="width:157px;">
<div style="width:157px;">

Before I try converting integers to floats (which will definitely blow hzip out the water) have you any other view

gnosygnu commented 5 years ago

Ugh. There is support for packed-hover, but something must have broke.

As for the floats, the implications are quite signficant. XOWA uses integers everywhere for width and height. It's a major change to make them floats, and I'm worried it may not be possible (the database assumes width and height are ints)

Does the fractional values make the gallery look that much different?

gnosygnu commented 5 years ago

Also, on a side note, I updated the About page tonight to officially recognize your contributions: http://xowa.org/home/wiki/Help/About . It's a very small token of appreciation for all the work you've done over the past few months. Please do let me know if you want any text changed, or if there is some better way to acknowledge your efforts.

And though I don't think I can say it too many times, let me say again, thank you for everything you've done! I am truly lucky to have your participation and really hope to do better on my side to catch up to all your tickets. Thanks!

desb42 commented 5 years ago

Thanks for the kind words As I have already said - this is a fascinating project that happens to resonate with what I am doing.

As to fractional values - there is a slight visual difference but not worth the upheaval

gnosygnu commented 5 years ago

Cool. No worries on the kind words -- they're very much deserved.

As for the fractional values, I'm going to mark this as a future enhancement and probably close in the near future. Thanks