search

gnosygnu / xowa

xowa offline wiki application
Other
375 stars 41 forks source link

<imagemap> needs some tweeking #386

Open desb42 opened 5 years ago

desb42 commented 5 years ago

Comparing page en.wiktionary.org/wiki/limb#Anagrams on xowa and mediawiki limb There are some obvious visual differences Looking at the html produced has high lit at least 3 issues - all relating to \ 1) error message is not displayed (although xowa does produce a warning in the session log) image_map failed to find lnki; page=en.wiktionary.org/wiki/limb imageMap=[[image:|150x75px|branch]]

2) images with maps that do not have any shapes should not produce \ 3) the little blue i (About this image) button does not appear

My branch imaps addresses the last 2 points

should the error message display?

gnosygnu commented 5 years ago

Thanks for the code sample at https://github.com/desb42/xowa/commits/imaps

Regarding question 1: Yeah, the error message should display. I've honestly not always been consistent with error messages and sometimes go the easy way of logging the error instead of trying to generate the HTML. I'll fix this and the other 2 issues above this weekend.

desb42 commented 5 years ago

Having done an enwiki html_dump Here are a couple of more pages exhibiting the lack of error on page but logged en.wikipedia.org/wiki/Wikipedia:WikiProject_Games/Advert en.wikipedia.org/wiki/List_of_CSX_Transportation_predecessor_railroads