Open desb42 opened 5 years ago
Great write-up. Just trying to fill in some gaps
<maplink> is a no-op extension. The extension links to online OpenStreetMap , which is sort of uesless in an offline environment. So in XOWA, I registered the maplink extension but just had it generate no HTML
With regards to UNIQ. I changed XOWA to follow MediaWiki's behavior. It uses UNIQ to armor pieces of text so that subsequent regexes don't change it.
The problem above is that UNIQ is armoring the contents of the maplink which, in turn, is empty. That's why it has zero bytes.
The correct resolution would be to implement maplink. But I don' t see much value to this (since OpenStreetMaps requires online access). Do the French Wikipedia pages look weird with the missing maplink?
I am still slightly confused as to why the breakpoint I set did not hit
As it happens (and I don't expect anyone else to) I have my own tile server.
The differences showing the maplink stuff and
so relatively minor - its just I like to see as little difference between xowa and mediawiki (it could just be text and no link)
There seems to be an issue with the #tag mechanism when used by lua through the :extensionTag function I have come across this in frwiki
If within the frwiki sandbox (Aide:Bac_à_sable) I write the following
The result should be something like
in xowa \ is vistigal; however there is enough code to place a breakpoint to see that it is processed (and ignored)
In running the above code through xowa the \ tag is not hit
Reviewing the module fr.wikipedia.org/wiki/Module:Coordinates the lines at issue for me are lines 384-393
When I put a
dbg(maplink)
following this code I get'"UNIQ--maplink-0-QINU"'
Which took me some time to pin down. I found something in Xop_uniq_mgr.java - Parse_recurse When it came to replacing the above UNIQ I found that this substitution had zero bytes(?)
Further work on looking at the Add function in this module showed that it added a UNIQ with zero bytes
My current suspicion is that it has something to do with the json construct (line 386)
I hope this make sense