gnosygnu / xowa

xowa offline wiki application
Other
378 stars 40 forks source link

De-En 2020-05 Wikipedia #717

Open Ope30 opened 4 years ago

Ope30 commented 4 years ago

Sup @gnosygnu, Ope30 here!

You (maybe) missed my last post I posted a while ago in which I said that the new XOWA build unfortunately didn't fix these bugs for me. But honestly, I've been using XOWA so much in the last few weeks that I (personally) no longer care about them. It‘s alright. I am used to it. Everything else works fine. Either way, I would still download a new version. Always.

The latest builds are 3 months old. What is your opinion on creating and publishing a new build, German and English 2020-05 Wikipedia? Decide for yourself if you have the free time to do this. If necessary, we can decide on 2020-06. 👍🏼

gnosygnu commented 4 years ago

Hey. Good to hear from you again.

You (maybe) missed my last post I posted a while ago in which I said that the new XOWA build unfortunately didn't fix these bugs for me

Yeah, sorry, missed that.

The latest builds are 3 months old. What is your opinion on creating and publishing a new build, German and English 2020-05 Wikipedia? Decide for yourself if you have the free time to do this. If necessary, we can decide on 2020-06. 👍🏼

I can try a German build, though not certain if 2020-05 or 2020-06. In brief, which is the worst bug that you're seeing in German? I can try to fix that before the next build

Other than that, hope everything is good for you in these times. Take care!

Ope30 commented 4 years ago

In brief, which is the worst bug that you're seeing in German? I can try to fix that before the next build

The worst bug for me personally is this one below, because it makes it hard to read the text the bug hides. Only city articles are affected because some of them, I think, contain Bundestag elections. The rest is at https://github.com/gnosygnu/xowa/issues/680 (JFYI)

I can try a German build, though not certain if 2020-05 or 2020-06.

Your choice. If you want to choose 2020-05, then do it. If you decide on 2020-06, then do it. You're the boss!

Other than that, hope everything is good for you in these times. Take care!

You too, Gnosy. I wish you and your relatives the best of health!

gnosygnu commented 4 years ago

The worst bug for me personally is this one below, because it makes it hard to read the text the bug hides. Only city articles are affected because some of them, I think, contain Bundestag elections. The rest is at #680 (JFYI)

Hmm, so this looks like the issue created here: #694

I know you said that you tried it...

You (maybe) missed my last post I posted a while ago in which I said that the new XOWA build unfortunately didn't fix these bugs for me.

But just to be sure, did you actually download the version from here? https://github.com/gnosygnu/xowa/issues/694#issuecomment-605512119

desb42@ also said he couldn't reproduce, so I'm a bit puzzled.

Can you try the steps in the Repro section, and leave a comment there? Will track progress accordingly.

Thanks!

Ope30 commented 4 years ago

But just to be sure, did you actually download the version from here? #694 (comment)

Yep, I‘m 100% sure. I‘m using XOWA 64 bit 4.6.6.2003. The .exe file says it too.

desb42@ also said he couldn't reproduce, so I'm a bit puzzled.

Me too. I don't understand why you two don't have the same problems I have. All I can think of is that I have an old version of Java installed on my computer, and downloading and installing the latest version might fix all that. I‘m not sure. Could this have something to do with it?

Can you try the steps in the Repro section, and leave a comment there? Will track progress accordingly.

Sure. Will leave a post there

Atlanta11 commented 4 years ago

Hmm, is it possible to download the English 2020-05 Wikipedia?

desb42 commented 4 years ago

To throw in my two cents (pennies)

Having taken a longer look at de.wikipedia.org/wiki/Bundestagswahl_2017 and the image posted by @Ope30, I note that xowa-gui menus are in German not English

This led me to the thought that the German locale may be affecting things (as both @gnosygnu and I use English/American) The expression errors being seen 'could' be due to decimal numbers being treated incorrectly

That is, the decimal point . is the character , in German I wonder if this is causing the #expr logic some problems The error Expression error: Unrecognised word "," could occur if a number, say 41.5, is treated as 41,5

desb42 commented 4 years ago

Just to follow up on my previous comment If I change the line

| ERGEBNIS1    = 32.9<!--bit ...

to

| ERGEBNIS1    = 32,9<!--bit ...

That is change . to , I get germanerr Which looks remarkably like @Ope30's screenshot

gnosygnu commented 4 years ago

@desb42 : Great find! I can reproduce something similar by setting my Windows Region to German

I think Luaj is probably using the user's region, whereas Lua is not. Let me dig through the code

Thanks!