search

gnosygnu / xowa

xowa offline wiki application
Other
381 stars 40 forks source link

islamic months not showing #837

Open desb42 opened 3 years ago

desb42 commented 3 years ago

en.wikipedia.org/wiki/Help:Time_function shows dates in various formats The Islamic month is not showing

On investigation the Islamic month names com from 400_xowa\src\gplx\xowa\xtns\pfuncs\times\Pft_fmt_itm_hijiri.java This tries to lookup month names (an example is hijiri-calendar-m1)

However in bin\any\xowa\cfg\lang\core\en.gfs the closest definition is for hijri-calendar-m1 Note that there is an extra i in the java file

I believe that HIJIRI is incorrect and should be HIJRI

Replacing all hijiri with hijri makes things work

gnosygnu commented 3 years ago

Hey, thanks for the great detail on the issue. Sorry for the lack of presence lately, but have had less time to spare

At any rate, fixed with the commit above. Thanks!

desb42 commented 3 years ago

I think that as the class Pft_fmt_itm_hijiri has been changed to Pft_fmt_itm_hijri the java filename also needs to be changed (to Pft_fmt_itm_hijri.java)

gnosygnu commented 3 years ago

Forgot about that. Pushed above. Thanks!