gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 73 forks source link

terminfo files are installed in DESTDIR #1

Closed duganchen closed 8 years ago

neeasade commented 8 years ago

LGTM, will merge this evening. This is also relevant to upstream.

http://git.suckless.org/st/tree/Makefile#n52

Thanks, Nathan

On Sun, Jun 19, 2016 at 3:33 PM, duganchen notifications@github.com wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/neeasade/xst/pull/1 Commit Summary

  • terminfo files are installed in DESTDIR

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/neeasade/xst/pull/1, or mute the thread https://github.com/notifications/unsubscribe/ADkuRNQO8sg5L5CtnvXEMG138bNIvIUYks5qNaeSgaJpZM4I5Pov .

duganchen commented 8 years ago

Would you be open to a pull request to add support for an Xresources-configurable alpha transparency option?

That's something that would make xst more cool for me. I can leave the default at "fully opaque" so that there's no change in behavior.

On Tue, Jun 21, 2016 at 2:21 PM, Nathan Isom notifications@github.com wrote:

Merged #1 https://github.com/neeasade/xst/pull/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/neeasade/xst/pull/1#event-699684563, or mute the thread https://github.com/notifications/unsubscribe/AAbUetUVn1ov9_ucqmGmygpQAxTEPH78ks5qOFXugaJpZM4I5Pov .

neeasade commented 8 years ago

I would be open to that -- we would probably expose as 'xst.opacity'. Are you referring to the existing patch for it?

edit: http://st.suckless.org/patches/alpha

duganchen commented 8 years ago

I am. I'll get started soon.

On Wed, Jun 22, 2016 at 4:46 AM, Nathan Isom notifications@github.com wrote:

I would be open to that -- we would propbably expose as 'xst.opacity'. Are you referring to the existing patch for it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/neeasade/xst/pull/1#issuecomment-227719664, or mute the thread https://github.com/notifications/unsubscribe/AAbUesa_TTRLgPppgMHWD4nFtSY_gDSJks5qOSCpgaJpZM4I5Pov .