search

gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 73 forks source link

Backspace in hanging process? #100

Closed tmpm697 closed 4 years ago

tmpm697 commented 4 years ago

xst 1:0.8.4.r0.gda50afd-1 os: archlinux up-to-date step:

> sleep 1000000
fdafdsfsfdasf^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^C

^H is backspace, I expect it will del previous char as in normal when edit command in prompt, I don't have issue with previous xst.

actionless commented 4 years ago

sidenote: in latest st this problem also not reproducible

actionless commented 4 years ago

@neeasade

in xst config.def.h i see:

    { XK_BackSpace,     Mod1Mask,       "\033\177",      0,    0},

while in st i see:

    { XK_BackSpace,     XK_NO_MOD,      "\177",          0,    0},
    { XK_BackSpace,     Mod1Mask,       "\033\177",      0,    0},
tmpm697 commented 4 years ago

yes, adding { XK_BackSpace, XK_NO_MOD, "\177", 0, 0}, worked.

actionless commented 4 years ago

@neeasade should we fix it in xst?

neeasade commented 4 years ago

@actionless yes, will PR

kpa28-git commented 4 years ago

I don't know if this is related to my problem but I notice now that I have to backspace twice to delete the first character in a string now. Subsequent backspaces work properly, but the first one requires two backspace presses.

EDIT: I realized the first backspace is occuring but there is a long delay (well over 500 ms) until it affects the input buffer. I haven't noticed this with any other key so far.

tmpm697 commented 4 years ago

You might decrease the keyrate in X window -- .xserverrc?

kpa28-git commented 4 years ago

I already decrease the xset rate delay for all keys in .xinitrc. I can try adding an extra delay for backspace. I also noticed the standard st package from the AUR doesn't have this issue. I think this started with a recent update of xst. Thanks for the suggestion though I'm going to try it if I don't find another resolution.

actionless commented 4 years ago

this started with a recent update of xst

could you please do git-bisect-ing for your usecase?

kpa28-git commented 4 years ago

I started at git tag v0.8.4. I got this output:

079cf8cd6bc811056750a10ec876d23a50ea6cce is the first bad commit commit 079cf8cd6bc811056750a10ec876d23a50ea6cce Author: neeasade neeasade@users.noreply.github.com Date: Sun Jul 12 16:44:28 2020 -0500

backspace definition -- fixes https://github.com/gnotclub/xst/issues/100 (#105)

config.def.h | 1 + 1 file changed, 1 insertion(+)

actionless commented 4 years ago

@kevindirect

any difference when applying this patch? https://github.com/gnotclub/xst/pull/107/files (it fixes another problem but i just thought those might be related)

actionless commented 4 years ago

@kevindirect sorry, the new link to PR: https://github.com/gnotclub/xst/pull/109 (for some reason force-pushing to closed PR makes it not possible to re-open it back)

actionless commented 4 years ago

(in order to test that patch you'll need either to apply it locally together with #108 or re-generate terminfo-s with tic manually)

neeasade commented 4 years ago

this issue is resolved for me with #109 (and after clearing out my stale ~/.terminfo)

kpa28-git commented 4 years ago

Same, issue was resolved for me on revision 11. Thanks