search

gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 73 forks source link

Add ligature Support #104

Closed arkhan closed 3 years ago

actionless commented 4 years ago

if that's an expected behavior?

2020-07-12--1594530037_88x35_scrot

arkhan commented 4 years ago

@actionless works fine,

img-2020-07-12-005108

neeasade commented 4 years ago

We'll want to make this opt-in through xresources, and consider notifying package maintainers of the new dependency

actionless commented 4 years ago

@arkhan you didn't got my example -- it not works when between symbols are invisible escape sequences for defining the color of the letters

neeasade commented 4 years ago

@actionless I see on the patch page:

Due to some limitations in drawing engine, ligatures will break when crossing colors, font styles or selection. They will still render properly as separate symbols, just not as ligatures.

arkhan commented 4 years ago

@actionless like this:

img-2020-07-16-161843

actionless commented 3 years ago

We'll want to make this opt-in through xresources

i think this is still a blocker for this PR to be merged

kanashimia commented 3 years ago

Breaks boxdraw.

actionless commented 3 years ago

why you did closed it?

arkhan commented 3 years ago

@actionless Unfortunately I find myself difficult of time to review the problems to be solved in this MR