gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 74 forks source link

nerd fonts look weird with vim and logo-ls #124

Closed siduck closed 3 years ago

siduck commented 3 years ago

nerd fonts look cut half in nerdtree in vim and logo-ls icons too image , it works in st tho :/ .

xst image

st

image

actionless commented 3 years ago

try to analyze the overall difference between your config.h of st VS config.h + xresources of xst

and post it here

actionless commented 3 years ago

if the problem still persists even while you totally sure configurations are the same -- try to git-bisect in xst at which commit it got broken

but my current guess it's a difference in font size or smth like using "Nerd Mono" in one and "Monospace" (resolving to the same Nerd Mono) in other or such kind of config things

siduck commented 3 years ago

if the problem still persists even while you totally sure configurations are the same -- try to git-bisect in xst at which commit it got broken

but my current guess it's a difference in font size or smth like using "Nerd Mono" in one and "Monospace" (resolving to the same Nerd Mono) in other or such kind of config things

that works but now the icon size is getting very small

(with font : JetBrainsMono Nerd Font Mono ) image

(with font : JetBrainsMono Nerd Font ) image

actionless commented 3 years ago

i still not convinced wht the same setting works differently in st vs xst

siduck commented 3 years ago

i still not convinced wht the same setting works differently in st vs xst

st on the left image

actionless commented 3 years ago

ok, let's do it other way around:

1) build totally vanilla st and xst, without any changes to config.h 2) reset your xrdb:

$ xrdb -q
$ xrdb -load /dev/null
$ xrdb -q

3) force the same font via cli arg:

st -f 'Your Font Name:pixelsize=20:antialias=true'
xst -f 'Your Font Name:pixelsize=20:antialias=true'
siduck commented 3 years ago

:pixelsize=20:antialias=true'

st image

xst

image

actionless commented 3 years ago

are you sure what font name and font size are the same?

on your screenshots xst evidentially have bigger font (however i don't think xst does any dpi-multiplication of font size or such, especially when xrdb is reset, it's for sure not obtaining any display information from xcb directly and such

it seems what in this situation the only resort is doing git bisect

btw just a sidenote, i can't reproduce it when doing the same steps as in my previous comment

siduck commented 3 years ago

are you sure what font name and font size are the same?

on your screenshots xst evidentially have bigger font (however i don't think xst does any dpi-multiplication of font size or such, especially when xrdb is reset, it's for sure not obtaining any display information from xcb directly and such

it seems what in this situation the only resort is doing git bisect

btw just a sidenote, i can't reproduce it when doing the same steps as in my previous comment

st seemed to have smaller font since that was the vanilla ST , with no xresources patch . Idk what git bisect does

actionless commented 3 years ago

if you ran xrdb .... commands above xresources patch shouldn't make any difference

Idk what git bisect does

https://stackoverflow.com/questions/4713088/how-to-use-git-bisect

siduck commented 3 years ago

oh that looks complex :l

actionless commented 3 years ago

i have one more last idea to try before bisect-ing, in xst config.h try to adjust unsigned int max_bold_weight_infelicity = 20; to 0

siduck commented 3 years ago

oh that doesnt work either :(

actionless commented 3 years ago

just to double-check, what's the output of your xrdb -q command while you did last test attempts?

actionless commented 3 years ago

(it must be empty, if you followed the steps without accidents)

siduck commented 3 years ago

yeah it was empty but still doesnt fix the issue :(

actionless commented 3 years ago

at this point the only possible solution i see what you (or anyone else who able to reproduce the issue) will do git bisect

siduck commented 3 years ago

at this point the only possible solution i see what you (or anyone else who able to reproduce the issue) will do git bisect

oh nvm I'll just make my own st build now . I had issues with the scroll mouse patch , I'll just use xst