gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 74 forks source link

no transparency #126

Closed ndowens closed 3 years ago

ndowens commented 3 years ago

https://termbin.com/7kz8

xst 0.8.4 with the above setting gives no transparency. I am using plasma with compositor enabled, opengl. Brought to my attention originally by https://github.com/void-linux/void-packages/issues/27070

vikigenius commented 3 years ago

This is broken by the latest update i think. It worked just before the recent update.

ndowens commented 3 years ago

This is broken by the latest update i think. It worked just before the recent update.

Yup, just tested older version and it works with 0.7.2

vikigenius commented 3 years ago

@ndowens, can you test if blinking cursors work for you in 0.8.4 ? I think the recent update broke that as well https://github.com/gnotclub/xst/issues/127

ndowens commented 3 years ago

With 0.7.2 mine doesn't blink either

vikigenius commented 3 years ago

@ndowens Hmm, mine does blink in 0.7.2 if i set:

st.cursorshape:       1
st.cursorthickness:   2
st.cursorblinkstyle:  0
st.cursorblinkontype: 1
st.blinktimeout:      800
ndowens commented 3 years ago

Hoping this gets resolved, or I will just revert to older version after giving sometime

vikigenius commented 3 years ago

master seems to be working just fine. Maybe it's time to just update to a new release version?

ndowens commented 3 years ago

master seems to be working just fine. Maybe it's time to just update to a new release version?

Will have to figure out which of the changes in master fixed the issue so can use it as a patch

actionless commented 3 years ago

some of the option names changed, make sure you are in-sync with example .Xresources config (https://github.com/gnotclub/xst/blob/master/.Xresources)

if smth still doesn't work, paste here the output of xrdb -q | grep '^st.' and diff of your config.h with config.h.def in case if you made there any changes as well

particularly with transparency there are 2 new options now, st.disable_alpha_correction and st.depth which both could affect the final result

actionless commented 3 years ago

also reports for not latest git master are not accepted

ndowens commented 3 years ago

also reports for not latest git master are not accepted

Why would releases not get support?

actionless commented 3 years ago

feel free to assign yourself to support them, @ndowens

ndowens commented 3 years ago

@vikigenius i will figure out which commit fixes it and I will orphan it if you want it

actionless commented 3 years ago

in that case, i can create 0.8.x branch and you could maintain it if you like, @ndowens

and new features we would do as now on master, and they will be release as 0.9-smth

sounds fine for you @neeasade ?

neeasade commented 3 years ago

I think a new release is fair given the decisions that were made after tagging 0.8.4 - let's tag 0.8.4.1.

(Also hello void users! I was afk yesterday evening)

On Fri, Dec 11, 2020, 8:32 AM Yauhen Kirylau notifications@github.com wrote:

in that case, i can create 0.8.x branch and you could maintain it if you like, @ndowens https://github.com/ndowens

and new features we would do as now on master, and they will be release as 0.9-smth

sounds fine for you @neeasade https://github.com/neeasade ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gnotclub/xst/issues/126#issuecomment-743225511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4S4RE7RYBR75E5LXEAQ4TSUIUPBANCNFSM4UV4ERDQ .

ndowens commented 3 years ago

Thanks for new release