gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
536 stars 74 forks source link

add reflow support #150

Closed RaafatTurki closed 1 year ago

RaafatTurki commented 1 year ago

The st terminal doesn't reflow text on terminal size change (which happens a lot on a tiling wm) and simply cut away the content.

I couldn't find a reflow patch on the official suckless site but I've found this reddit post, The person behind that has actually extracted this patch from this st fork

I think this patch should be applied by someone who knows the xst source better than I do, reflowing should make a fine addition to xst.

actionless commented 1 year ago

why not just using tmux though? πŸ€”

RaafatTurki commented 1 year ago

@actionless This solution is niche, overkill, and a crutch that comes with many issues:

I'm sure there are more points to this that would arise when this solution is put to practice.

actionless commented 1 year ago

i think after you'll actually remove the qeustion marks by finding answers to your questions, the amount of those points would be "a bit" less πŸ˜ΊπŸ‘

RaafatTurki commented 1 year ago

I think we're deviating from the subject here, this issue is about the reflow patch, not tmux.

I don't want to use tmux the way you're suggesting and I believe most users would agree w me, The points I've provided were illustrative of what users (including myself) would need to go through just to get their terminal to reflow according to your solution.

actionless commented 1 year ago

i am still not convinced - i see point adding features which could be done ONLY on the level of terminal itself, but if it's smth could be done in a terminal multiplexer/shell/other app - i personally prefer keeping terminal to do only minimal required job. other maintainers may not agree with me, so i'll leave the discussion open, until we'll have some generic policy on such sort of features

apprehensions commented 1 year ago

https://st.suckless.org/patches/scrollback/st-scrollback-reflow-0.8.5.diff

:)

RaafatTurki commented 1 year ago

https://st.suckless.org/patches/scrollback/st-scrollback-reflow-0.8.5.diff

Didn't know that exists, This simplifies a lot of this issues since scrollback is already patched. @neeasade @actionless I need the green light to PR this in.

neeasade commented 1 year ago

that's a big patch. going to echo @actionless and say if you want reflow in xst, use tmux (thank you for the interest and linking it though)

RaafatTurki commented 1 year ago

I understand. Closing since builtin reflow support is not within the vision of xst.