search

gnotclub / xst

st fork that uses Xresources and some pretty good patches
MIT License
537 stars 73 forks source link

Buffer overflow when running from Ubuntu #6

Closed waldnercharles closed 8 years ago

waldnercharles commented 8 years ago

I'm able to make install just fine, but when i run st, I get a buffer overflow detected. I do not get this error when running st from suckless.org.

waldnercharles commented 8 years ago

It looks like https://github.com/neeasade/xst/blob/master/src/st.c#L4459 needs to have its length extended to 12 to account for the trailing null character that sprintf adds.

neeasade commented 8 years ago

thanks for the issue and PR.