gnovakowski
commented
10 years ago Sir,
The grades are as follows:
Prelab – Check minus
Required – Complete, but 1 day late
B – 0
A – 0Very Respectfully,
// SIGNED //
Geoffrey Paul Novakowski
CS-35, “Weasels”
USAF Academy
From: Todd Branchflower [mailto:notifications@github.com] Sent: Thursday, February 27, 2014 11:08 AM To: gnovakowski/Lab_2 Subject: [Lab_2] Grades (#1)
Where are your prelab / functionality grades / timeliness? Zeroes until I get them.
Prelab - 0
Required - 0 B - 0 A - 0
Use of Git - 2 - You can do better than this. It's clear you didn't use git all along and are simply adding files one at a time. You should be committing functionality increments - these often involve code changes across files. Code Style - Check Minus - 3 - Get rid of that boilerplate header! You've got some indentation issues - be consistent! Replace "00100000000" with an unsigned value, then cast to std_logic_vector if necessary. No comments at all? I need at least something above a block of code to tell me what I'm looking at. Ton of magic numbers in pixel_gen - use constants! README - 10 - Describe the problem better! What are the challenging parts of implementing pong and how does your FSM address them? Looks like there's a placeholder for an FSM picture - but it's not in your repo. Use your code examples to illustrate helpful constructs - don't just plo p down a huge block and say "that's how it works".
Your Test / Debug and Conclusion sections are identical to Lab 1. Not cool.
Total - 15
— Reply to this email directly or view it on GitHub https://github.com/gnovakowski/Lab_2/issues/1 .Description: Image removed by sender.
Where are your prelab / functionality grades / timeliness? Zeroes until I get them.
Prelab - 7
Required - 40 - 10% for 1 day late = 36 B - 0 A - 0
Use of Git - 3 - You can do better than this. It's clear you didn't use git all along and are simply adding files one at a time. You should be committing functionality increments - these often involve code changes across files. Code Style - Check Minus - 3 - Get rid of that boilerplate header! You've got some indentation issues - be consistent! Replace
"00100000000"with an unsigned value, then cast tostd_logic_vectorif necessary. No comments at all? I need at least something above a block of code to tell me what I'm looking at. Ton of magic numbers inpixel_gen- use constants! README - 10 - Describe the problem better! What are the challenging parts of implementing pong and how does your FSM address them? Looks like there's a placeholder for an FSM picture - but it's not in your repo. Use your code examples to illustrate helpful constructs - don't just plop down a huge block and say "that's how it works".Your Test / Debug and Conclusion sections are identical to Lab 1. Not cool.
Total - 59