search

gnoverse / gnochess

User-friendly chess dApp in Gno ecosystem
https://gnochess.com
GNU General Public License v3.0
16 stars 10 forks source link

feat: add support for realm faucet #180

Open zivkovicmilos opened 1 year ago

zivkovicmilos commented 1 year ago

Description

This PR adds support for the Realm fund method, outlined in #163

This PR is dependent on #163 being merged out and deployed.

netlify[bot] commented 1 year ago

Deploy Preview for gnochess canceled.

Name Link
Latest commit df7754394d253b9b82dd2e4cc3b1061c5785f80e
Latest deploy log https://app.netlify.com/sites/gnochess/deploys/65134a21656a1f00085419e3
netlify[bot] commented 1 year ago

Deploy Preview for gnochess-signup-form canceled.

Name Link
Latest commit df7754394d253b9b82dd2e4cc3b1061c5785f80e
Latest deploy log https://app.netlify.com/sites/gnochess-signup-form/deploys/65134a21a7419500089ced3f
moul commented 1 year ago

Looks good, however, there is a question regarding the realm path.

I initially started adding the register in r/demo/chess/register, but @harry-hov made something different in #171; I think his proposal makes sense but implies updating some commands. From what I see, there is not breaking change, but just habit changes.

I'd like the team to consider the options before merging #163 and then your PR.