search

gnu-octave / statistics

The Statistics package for GNU Octave
GNU General Public License v3.0
24 stars 22 forks source link

Added input validation tests in `glmfit` #131

Closed ruchikasonagote closed 5 months ago

ruchikasonagote commented 5 months ago

(https://github.com/gnu-octave/statistics/issues/126)

pr0m1th3as commented 5 months ago

Fix the error messages to conform with the standard used in statistics, i.e. the function name should be at the beginning of the error message. There are quite a few other issues stated in issue #125 . Try to fix them and make one PR addressing most if not all of these. Additionally, a demo block demonstrating the use of the function would be helpful and very welcome.

ruchikasonagote commented 5 months ago

Sure, I will fix the error messages and write the demo block. Regarding Issue #125, I have used fminsearch and I am working on adding support for other distributions within glmfit. I will try to finish it and make a PR till this weekend.

pr0m1th3as commented 5 months ago

Make sure you pull the latest glmfit since PR #139 has been merged.