search

gnu-octave / statistics

The Statistics package for GNU Octave
GNU General Public License v3.0
24 stars 22 forks source link

gumbelinv is incorrect #145

Closed nir-krakauer closed 3 months ago

nir-krakauer commented 3 months ago

Because of a misplaced minus sign, the value returned by the current gumbelinv function is incorrect. Attached patch fixes it and adds a test for correctness. gumbelinv_diff.txt

pr0m1th3as commented 3 months ago

@nir-krakauer I am traveling once again during this week. Could you make a PR so I can merge it from my mobile phone, please?

nir-krakauer commented 3 months ago

Like this? https://github.com/nir-krakauer/statistics/pull/1

pr0m1th3as commented 3 months ago

I cannot merge the PR to your own personal clone of the statistics repo. Merge your PR there and then make a PR to the /gnu-octave/statistics repo so I can merge it.

pr0m1th3as commented 3 months ago

The PR has been merged. Thanks! Closing this issue