search

gnu-octave / statistics

The Statistics package for GNU Octave
GNU General Public License v3.0
25 stars 23 forks source link

Shadow mean function from core depending on Octave version. #17

Closed mmuetzel closed 2 years ago

mmuetzel commented 2 years ago

Like we discussed during last maintainers meeting, functions from core Octave should only be shadowed conditionally (if at all). E.g., they should only be shadowed for Octave versions for which we know that we need to shadow them.

This PR suggests a possible implementation of that conditional shadowing for the function mean.

I hope this can land before a potential release of the package.

pr0m1th3as commented 2 years ago

I have already an implementation for that in my local repo with the mean function in a separate shadowing folder as you suggested at discourse. I haven't had the time to test it yet with other versions before pushing it to main. Thanks for the PR though, but the ADD and DEL files also contain other instructions as well, so I will close this PR without merging it to main. It will definitely be included in the next release of statistics package.